Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate WaitOnError #3439

Closed
epage opened this issue Feb 10, 2022 · 0 comments
Closed

Deprecate WaitOnError #3439

epage opened this issue Feb 10, 2022 · 0 comments
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies E-hard Call for participation: Experience needed to fix: Hard / a lot M-breaking-change Meta: Implementing or merging this will introduce a breaking change.

Comments

@epage
Copy link
Member

epage commented Feb 10, 2022

WaitOnError is a fairly specialized setting and only helps with argument parsing and not any other part of the application. This is also relatively easy for the user to implement. If we're not wanting to customize error codes, we have less reason to be in the business of waiting on error.
@epage epage added C-bug Category: Updating dependencies M-breaking-change Meta: Implementing or merging this will introduce a breaking change. E-hard Call for participation: Experience needed to fix: Hard / a lot A-parsing Area: Parser's logic and needs it changed somehow. labels Feb 10, 2022
@epage epage mentioned this issue Feb 10, 2022
Closed
@epage epage closed this as completed in de7c81e Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parsing Area: Parser's logic and needs it changed somehow. C-bug Category: Updating dependencies E-hard Call for participation: Experience needed to fix: Hard / a lot M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage