Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish support for native completions #3917

Open
epage opened this issue Jul 13, 2022 · 6 comments
Open

fish support for native completions #3917

epage opened this issue Jul 13, 2022 · 6 comments
Labels
A-completion Area: completion generator C-enhancement Category: Raise on the bar on expectations E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. 💸 $20

Comments

@epage
Copy link
Member

epage commented Jul 13, 2022

See #3166 for more context

@epage epage added C-enhancement Category: Raise on the bar on expectations A-completion Area: completion generator E-easy Call for participation: Experience needed to fix: Easy / not much labels Jul 13, 2022
@ModProg
Copy link
Contributor

ModProg commented Sep 2, 2022

I wanted to start on this, looking at the current structure with bash, would it make sense to move the bash mod into a separate file, and could/should some of the bash code be reused instead of duplicated, and therefore extracted into a shared module for utils?

@epage
Copy link
Member Author

epage commented Sep 2, 2022

I mostly kept it a single file for ease of prototyping. It will make sense to split it into another file. Please do that in a separate commit from other work so its easier to track whats going on

@epage epage added 💸 $20 E-help-wanted Call for participation: Help is requested to fix this issue. labels Sep 13, 2022
@ModProg
Copy link
Contributor

ModProg commented Oct 3, 2022

Have the PR setup now for review. Still open things, especially in the handling of more complex functionality in handling parsing errors or arguments taking multiple values.

Also there might be some ways to unify code with claps actual parsing logic, but as I'm not familiar with it, I skipped that for now.

@epage
Copy link
Member Author

epage commented Oct 3, 2022

Also there might be some ways to unify code with claps actual parsing logic, but as I'm not familiar with it, I skipped that for now.

Yeah, I hope to find a way to merge it one day but I figure its better for us to learn what is expected first

@ModProg
Copy link
Contributor

ModProg commented Oct 4, 2022

Yeah, I hope to find a way to merge it one day but I figure its better for us to learn what is expected first

Yeah makes sense. There is probably also a bunch of parsing/error handling that can be skipped for completions.

@ModProg
Copy link
Contributor

ModProg commented Jul 31, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion Area: completion generator C-enhancement Category: Raise on the bar on expectations E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. 💸 $20
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants