Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hiding flags/subcommands/possible values/aliases for native compeletions #3951

Open
epage opened this issue Jul 19, 2022 · 4 comments · May be fixed by #5283 or #5549
Open

Support hiding flags/subcommands/possible values/aliases for native compeletions #3951

epage opened this issue Jul 19, 2022 · 4 comments · May be fixed by #5283 or #5549
Labels
A-completion Area: completion generator C-enhancement Category: Raise on the bar on expectations E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. 💸 $20

Comments

@epage
Copy link
Member

epage commented Jul 19, 2022 •
edited
Loading

We shouldn't offer hidden options by default but complete them if the user starts typing them

See #3166 for more details on native completions
@epage epage added C-enhancement Category: Raise on the bar on expectations A-completion Area: completion generator E-easy Call for participation: Experience needed to fix: Easy / not much labels Jul 19, 2022
This was referenced Jul 19, 2022
Open
Open
@epage epage added 💸 $20 E-help-wanted Call for participation: Help is requested to fix this issue. labels Sep 13, 2022
@epage epage mentioned this issue Sep 26, 2022
Closed
2 tasks
@epage epage mentioned this issue Apr 21, 2023
Open
2 tasks
@siketyan siketyan linked a pull request Jan 4, 2024 that will close this issue
Open
@nasso nasso mentioned this issue Mar 21, 2024
Closed
@shannmu
Copy link

shannmu commented Jun 21, 2024

i will work on this later.

@epage epage changed the title Support hiding flags/subcommands/possible values for native compeletions Support hiding flags/subcommands/possible values/aliases for native compeletions Jun 21, 2024
@epage
Copy link
Member Author

epage commented Jun 21, 2024

Before we do this:

  • We should make sure subcommand visible aliases are supported

In doing this, we should hide hidden items by default unless there are no other completions available.

@epage
Copy link
Member Author

epage commented Jun 21, 2024

PR #5283 started work on this but it seemed to have stalled out

Per usual, I would like to see

  • Tests added / updated in one commit, showing current behavior
  • As features are implemented, update the tests so they show the new behavior and the diff shows the change in behavior

@shannmu shannmu linked a pull request Jun 25, 2024 that will close this issue
Open
@epage
Copy link
Member Author

epage commented Jul 5, 2024 •
edited
Loading

Something @shannmu called out is our idea for showing hidden content is only if the user started it, we'll never be able to show hidden short flags or hidden short flag aliases. We'll still need to make sure we can complete values for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-completion Area: completion generator C-enhancement Category: Raise on the bar on expectations E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. 💸 $20
Projects
None yet
Milestone
No milestone
2 participants
@epage @shannmu