Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Use value parsers for external subcommands #3990

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

epage
Copy link
Member

@epage epage commented Jul 25, 2022

This changes the default type as well to encourage preserving the full
information for shelling out. If people need UTF-8, then they can
change the value parser.

Fixes #3733

This gives us more implementation flexibility
This changes the default type as well to encourage preserving the full
information for shelling out.  If people need UTF-8, then they can
change the value parser.

Fixes clap-rs#3733
@epage epage merged commit 62c75a0 into clap-rs:master Jul 25, 2022
@epage epage deleted the external branch July 25, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting external subcommand type is inconsistent with args
1 participant