Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Alias API / code #4421

Open
epage opened this issue Oct 24, 2022 · 0 comments
Open

Simplify Alias API / code #4421

epage opened this issue Oct 24, 2022 · 0 comments
Labels
A-builder Area: Builder API C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change. S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing

Comments

@epage
Copy link
Member

epage commented Oct 24, 2022

Currently, we have visible and non visible aliases along with singular and multiple methods.

One way of simplifying this is if we had a Alias<T> that had a hide(yes: bool) function. Arg::alias would implicitly convert strings to Alias or people could directly construct an alias and set it to hidden.

This would change Arg::alias from hidden to visible. The reason I'm suggesting that is to be consistent with our hiding of content. Maybe a visible would be justified, unsure.
@epage epage added C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change. A-builder Area: Builder API S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing labels Oct 24, 2022
@epage epage mentioned this issue Oct 24, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-builder Area: Builder API C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change. S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage