Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build with any version of Clap 4 due to rustix dependency #4571

Closed
2 tasks done
ghuh opened this issue Dec 22, 2022 · 3 comments
Closed
2 tasks done

Can't build with any version of Clap 4 due to rustix dependency #4571

ghuh opened this issue Dec 22, 2022 · 3 comments
Labels
C-bug Category: Updating dependencies

Comments

@ghuh
Copy link

ghuh commented Dec 22, 2022

Please complete the following tasks

Rust Version

rustc 1.66.0 (69f9c33d7 2022-12-12)

Clap Version

4.0.x (All patch versions up to at least 30)

Minimal reproducible code

Just build with any version of Clap 4.0 and above.

Steps to reproduce the bug with the above code

Need to be on Rust stable.

Actual Behaviour

   Compiling rustix v0.36.5
error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /Users/sambas/.cargo/registry/src/github.com-1ecc6299db9ec823/rustix-0.36.5/src/lib.rs:99:26
   |
99 | #![cfg_attr(rustc_attrs, feature(rustc_attrs))]
   |                          ^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0554`.
error: could not compile `rustix` due to previous error

Expected Behaviour

The build should complete. If I downgrade to Clap 3.2 and change nothing else, it builds fine.

Additional Context

No response

Debug Output

No response

@ghuh ghuh added the C-bug Category: Updating dependencies label Dec 22, 2022
@epage
Copy link
Member

epage commented Dec 22, 2022

I believe we got our dependence on rustic in 4.0.27.

Unfortunately, I can't reproduce this

  • I'm on 1.66 and updated my rustix version and I can't reproduce this.
  • CI is running on all major platforms with rustix 0.35.13 and 0.36.4 in the dependency tree and building successfully.

@ghuh
Copy link
Author

ghuh commented Dec 22, 2022

I just tried reproducing on two other computers and the build worked fine on both of them so this must be something specific to the environment on this one computer. Thanks for checking!

@ghuh ghuh closed this as completed Dec 22, 2022
@ghuh
Copy link
Author

ghuh commented Dec 22, 2022

For posterity: this can be fixed with a simple cargo clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Updating dependencies
Projects
None yet
Development

No branches or pull requests

2 participants