refactor(derive): Clean up unnecessary noop parsing #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My guess is this was left over from switching to using the type based API. The generated code for extracting values from `ArgMatches` had some code that didn't actually do anything, like mapping over the identity function, and wrapping a value in an `Ok` only to immediately use "?" on it.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My guess is this was left over from switching to using the type based API. The generated code for extracting values from
ArgMatcheshad some code that didn't actually do anything, like mapping over the identity function, and wrapping a value in anOkonly to immediately use "?" on it.