Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put clap_complete behind a feature flag instead of a separate crate #4949

Closed
2 tasks done
contagnas opened this issue Jun 5, 2023 · 1 comment
Closed
2 tasks done
Labels
A-completion Area: completion generator C-enhancement Category: Raise on the bar on expectations S-wont-fix Status: Closed as there is no plan to fix this

Comments

@contagnas
Copy link

Please complete the following tasks

Clap Version

master

Describe your use case

Currently clap_complete is shipped as a separate crate. This hurts discoverability (at least for me), and means users need to keep the dependency versions in sync.

Describe the solution you'd like

Put clap_complete behind a feature flag, like derive

Alternatives, if applicable

No response

Additional Context

No response

@contagnas contagnas added the C-enhancement Category: Raise on the bar on expectations label Jun 5, 2023
@epage
Copy link
Member

epage commented Jun 5, 2023

clap used to include completions (see App::gen_completions and it was intentionally split out as part of the v3 effort.

Features have several usability problems in Rust though some are made up for with some unstable rustdoc features we use with docs.rs.

In my mind, the better route for us to be going is to leverage rust-lang/rfcs#3243 when its approved.

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
@epage epage added A-completion Area: completion generator S-wont-fix Status: Closed as there is no plan to fix this labels Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion Area: completion generator C-enhancement Category: Raise on the bar on expectations S-wont-fix Status: Closed as there is no plan to fix this
Projects
None yet
Development

No branches or pull requests

2 participants