Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wrap_help a default feature #5013

Open
epage opened this issue Jul 17, 2023 · 0 comments
Open

Make wrap_help a default feature #5013

epage opened this issue Jul 17, 2023 · 0 comments
Labels
A-help Area: documentation, including docs.rs, readme, examples, etc... C-enhancement Category: Raise on the bar on expectations M-minor-incompat Meta: Implementing or merging this will require a minor version bump S-waiting-on-decision Status: Waiting on a go/no-go before implementing

Comments

@epage
Copy link
Member

epage commented Jul 17, 2023

In clap v3, terminal wrapping was always available

  • wrap_help wasn't about wrapping but auto-detecting the width
  • unicode make it correctly detect unicode character widths

In clap v4, we restructured this

  • wrap_help encompassed both wrapping and auto-detecting the width
  • unicode remained the same

We also kept wrap_help as non-default, moving wrapping from built-in to being non-default.

The theory behind it was that its a lot of code for processing for that some minor tweaks could make "good enough".

However, enough people seem to run into this being missing that we should probably make it default again. Anyone who is optimizing for size likely has default-features = false and this won't affect.

@epage epage added C-enhancement Category: Raise on the bar on expectations S-waiting-on-decision Status: Waiting on a go/no-go before implementing A-help Area: documentation, including docs.rs, readme, examples, etc... M-minor-incompat Meta: Implementing or merging this will require a minor version bump labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-help Area: documentation, including docs.rs, readme, examples, etc... C-enhancement Category: Raise on the bar on expectations M-minor-incompat Meta: Implementing or merging this will require a minor version bump S-waiting-on-decision Status: Waiting on a go/no-go before implementing
Projects
None yet
Development

No branches or pull requests

1 participant