Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML5: autoPlay fires incorrectly the PLAYBACK_PLAY_INTENT #1131

Closed
leandromoreira opened this issue Aug 26, 2016 · 5 comments
Closed

HTML5: autoPlay fires incorrectly the PLAYBACK_PLAY_INTENT #1131

leandromoreira opened this issue Aug 26, 2016 · 5 comments

Comments

@leandromoreira
Copy link
Member

clappr/clappr-stats#3
@tjenkinson
Copy link
Contributor

@leandromoreira what's the bug?

@leandromoreira
Copy link
Member Author

It fires PLAYBACK_PLAY_INTENT directly from constructor before any listener can handle this event.

@leandromoreira
Copy link
Member Author

leandromoreira commented Aug 26, 2016 •
edited

@tjenkinson did you see any issue if we go with this? (besides two broken tests)

-    this.options.autoPlay && this.play()
+    this.options.autoPlay && process.nextTick(() => this.play())

@tjenkinson
Copy link
Contributor

Ah this problem again :/

@leandromoreira
Copy link
Member Author

@tjenkinson we're working on a solution for this right now, it shouldn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leandromoreira @tjenkinson