-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFYI: Shaka 2 coming soon #4
Comments
Congrats @joeyparrish and the team, I'm looking forward for this, thanks for all the work! 🍻 |
Fixed links: redesign and it already points to master 😀 |
Yes indeed! We recently merged to master and hope to release beta soon. |
We've just released v2.0.0-beta on github & npm. Let us know what you think. We're still working on the v2 upgrade guide, but we have tutorials on several other topics already. Hopefully that will be enough to get you started, and you can always reach out via email or github if there's anything we can do to help with the transition. Thanks! |
Thanks @joeyparrish and all the team, soon I'll be trying it. |
It's looking pretty cool, although I just read the first two pages from the tutorial. But it was enough to make it work. The only thing I think we'll need to overcome is that, now the checking if the Browser/Device is able to play become an async method Player.support which returns a Promise. And on Clappr, we have a sync static method canPlay (that must use the Anyway, I think the full integration will be seamless, thanks once again. I'll try to dig deeper in the design and general changes. (looking forward to test a replace plugin for network request using WebRTC to offer P2P) |
I'm noticing a lot less "rebuffering" maybe it's because now the example stream is hosted in a better place http://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd |
We have always tried to avoid doing anything CPU-heavy in Shaka, and we took extra care with Regarding |
Yeah, there was one guy that opened an issue for that and I think it's very useful. I was thinking about offering a sync basic implementation (which will work for most cases) and postpone the final decision based on |
Yet on the feedbacks, the code is easier to read and extend :) |
Glad to hear it! |
|
New configuration with that many options to fine tune is pretty cool! |
@joeyparrish I'm listening to The same for the 'adaptation' event, I'm not seeing any |
Despite the |
With regard to buffering events, there should definitely be a shaka.Player.prototype.onBuffering_ = function(buffering) {
// Before setting |buffering_|, update the time spent in the previous state.
this.updateStats_();
this.buffering_ = buffering;
var event = new shaka.util.FakeEvent('buffering', { buffering: buffering });
this.dispatchEvent(event);
};
Does this help? |
Thanks @joeyparrish , it does help! About the 'buffering' event, what I did was to add a listener for 'buffering' |
Ah, it looks like a renaming bug in the compiled version. The property has been renamed, but it shouldn't have been. I filed shaka-project/shaka-player#361 to track. |
I see, I bet is that About the adaptation: I needed to offer separated tracks for each type, doing a simple filter |
We will have another beta release (v2.0.0-beta2) this week if possible. I will try to have the event properties (shaka-project/shaka-player#361) fixed in that release. Regarding adaptation, from your link it seems that you already have a solution. Or perhaps I don't fully understand the problem. Can you clarify, please? Do you need track information in the |
Yes, it's a solved problem, I'm just sharing what I did, I personally think it's best to offer a generic and extensible component. |
@joeyparrish yet on the adaptation event, it seems that when you call // turn on or off (depends on the user selection)
this._player.configure({abr: {enable: !isAuto}})
this._player.selectTrack(track) I logged the events and I got:
But there is no |
That's correct. AdaptationEvents are for changes made by the AbrManager. When you call |
is this sync? I mean, right after I call |
@joeyparrish do you have a slacker channel or other way (irc...) to communicate? |
Yes, it's synchronous, with the understanding that the StreamingEngine may not request a new segment right away. But the next time it does, it's from the new track. Sorry, I'm not available for live chat at the moment. We don't have an IRC or slacker channel for the team, either. If email works for you, you can find my email address in CONTRIBUTORS. |
Thanks , then I'll use it as sync method. I'm having some ideas (mostly about extensibility) but maybe the better place to discuss them it's here. |
Yes, please give us feedback on the API while we are still in beta and can make API changes more easily. The best place for feedback is either the mailing list or github issues. Thanks! |
I tried to access these "methods" ( var manifest = shaka.media.ManifestParser.support();
var media = shaka.media.MediaSourceEngine.support(); I saw you using it like a static method. |
Those methods are not exported from the library. They are "public" within the library (class-to-class), but "private" with respect to the application. |
The new version fixed the buffering issue (among tons of other), thanks! |
@leandromoreira, we've just released v2.0.0-beta3 on github & npm. The upgrade guide is available here. Let us know what you think! |
@joeyparrish thanks :) I'll take a look later! |
It took so long because I was busy with olympic games
player.configure({
drm: {
servers: {
'com.widevine.alpha': '//widevine-proxy.appspot.com/proxy'
'com.microsoft.playready': '//playready.directtaps.net/pr/svc/rightsmanager.asmx'
}
}
});
I found that the Player events documentation can mislead people, the idea of Player eventsv1
v2
But that's my own preference though. Plus the tutorial plugin is a great addition too. I'm really looking forward for the 🤘 2️⃣ |
Cool, thanks for the feedback! |
@joeyparrish are any plans to add support to the DRM solution Adobe Access? |
We don't not support Adobe Access. We support EME, so as long as Adobe Access is interoperable with other EME key systems, I see no reason it shouldn't just work. That said, we currently have no public DASH test vectors using Adobe Access, so we can't confirm. |
Thanks @joeyparrish I got it. |
Just wanted to let you know that v2.0.0 is officially out of beta. Thanks again for your involvement and feedback! |
@joeyparrish you're welcome, btw we (the company I'm currently working) are planing to use Shaka very soon ! (actually we use clappr therefore we'll use this wrapper (dash-shaka-playback) but for sure Shaka is the ⭐ while playing dash) |
Nice! |
JFYI, Shaka team is hard at work on Shaka 2, which will have a new API. You can see a preview of the work-in-progress on the preview branch. We also published a redesign doc with a roughed-out version of the new APIs and diagrams of the new architecture.
I'll update this ticket once we go into beta so that you have a chance to give feedback on the API and start working on updates to your clappr plugin to support Shaka 2. We expect the official release of Shaka 2.0.0 by end of March. Thanks!
The text was updated successfully, but these errors were encountered: