Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed buff duration from delay to a timer #22

Merged
merged 1 commit into from
Dec 14, 2021
Merged

changed buff duration from delay to a timer #22

merged 1 commit into from
Dec 14, 2021

Conversation

biaferre
Copy link
Collaborator

What I did

  • Added a timer to regulate the duration of each buff
    • Monica has 3 seconds to collect it before it goes away
    • includes disappearance in event queue

How to test

  1. Open the terminal and go to the folder of this project

  2. In terminal:

    1. git checkout develop
    2. git pull
    3. git checkout <branch name>
    4. git pull origin <branch name>
    5. yarn install
    6. code .
    7. sudo docker-compose up
    8. yarn typeorm migration:run
    9. yarn start
  3. In your browser go to http://localhost:3000/

  4. In VScode open <relative path>

  5. Things to do during the code:

    • Open insomnia and postbird to test the requisitions needed
  6. Read the changed files section on GitHub

  7. Test the things that you think are worth testing, even the ones that are not in this description

 


Time spent: 40'

Copy link
Collaborator

@SamuelMarsaro SamuelMarsaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@SamuelMarsaro SamuelMarsaro merged commit d880764 into main Dec 14, 2021
@claraabk claraabk deleted the buff branch December 14, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants