Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto upgrade #34

Closed
wants to merge 9 commits into from
Closed

Auto upgrade #34

wants to merge 9 commits into from

Conversation

sw0x2A
Copy link

@sw0x2A sw0x2A commented Oct 13, 2015

Following changes let Puppet download a new release and installs the binary when the version variable has been changed. Furthermore, since release 0.11.0 consul-template comes as zip rather than a tar.gz, so I changed download url and how to extract it.

@gdhbashton
Copy link
Contributor

Hey Stefan,

Thanks for the PR! Apologies for the delay - I'm just back from holiday..

Can I ask that you rebase against current master? I pushed some changes last Friday, just a couple of hours before consul-template 0.11.0 was released, which set the default install version to 0.10.0 - so your PR is currently merge conflicting.

Further, I notice that your changes mean that only versions 0.11.0 and newer can be supported, and I'm not in favour of that - I would like to preserve compatibility for users who choose (or must) pin to a specific older version of consul-template - so I'd need to see some conditional logic to switch behaviour for .tar.gz or .zip with versioncmp()

@gdhbashton
Copy link
Contributor

Superceded by #36

@gdhbashton gdhbashton closed this Oct 19, 2015
@sw0x2A
Copy link
Author

sw0x2A commented Oct 19, 2015

The other PR doesn't fix the issue that a newer version is not automatically upgraded but require the staging file and consul-template binary to be removed manually so Puppet installs the new version. Interested in a PR with only this change?

@gdhbashton
Copy link
Contributor

Yup sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants