add proper permissions to config and template files #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-jester
force-pushed
the
AJ-fix-config-files
branch
from
4096e79
to
85b8031
Compare
| @@ -49,14 +52,21 @@ | |||
| # [*data_dir*] | |||
| # Path to a directory to create to hold some data. Defaults to '' | |||
| # | |||
| # [*user*] | |||
| # Name of a user to use for dir and file perms. Defaults to `false`. | |||
There was a problem hiding this comment.
Defaults to consul-template
|
Yep I like this - just a couple of cosmetic typos and we're good to merge. |
aj-jester
force-pushed
the
AJ-fix-config-files
branch
from
85b8031
to
4d0cf1d
Compare
|
Good catch! fixed. |
gdhbashton
added a commit
that referenced
this pull request
Dec 8, 2015
add proper permissions to config and template files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the permissions on the config files where the token is stored is world readable. This PR makes the default
0660and also refactored how user/group is created inside the module so if the user/group is created outside the module we can still pass the values to the resources inside the module.