-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to relate between data packages, study types and calculation methods? #91
Comments
Data Package filtering is not implemented ATM: you could select a data package that does not contain any data for the selected study area. So this is a more general problem. I would put this on hold and come back when we have our 1st screening data package defined and are actually able to create, calculate, visualise and asses (MCDA!) screening studies. |
After discussion with @patrickkaleta, this is what we recommend Step 1: add a field to the data package to indicate which calculation methods (1..* if we count "no calculation" method as one) it supports. Step 1 is easy, we should do it ASAP. Step 2: assure that only the data packages are shown that provide (resources for) all the calculation methods that the study type requires This is more difficult, but we have done something similar on DRIVER already (choice of solutions in trial). @fgeyer16 , do you remember what was necessary fo this to work? Maybe this: https://www.drupal.org/project/entity_browser/issues/2790951 ? Step 2b: also take into account the spatial aspect. If the data package is for Italy and the study is in Austria, it should not be shown. This is similar to step 2, but involves geospatial "is polygon A within polygon B" operation. I have no idea if this is supported in Drupal. |
Step 1 is implemented. |
Since I had a little bit of time I had a look at this issue again...
This was done already weeks ago. DP has a field calculations methods (1..*) and it references our Calculation methods taxonomy
In theory this is possible, but how would this even work? Let's assume a study type has Emikat and another external service as calculation methods. Which one will then perform the calculations? Both? Which results will we then display? etc etc...
It's not difficult when we use a simple select list instead of the current Entity Browser. The current implementation is confusing anyway (at least to me), so switching to a simple select list + adding the "show preview" widget created by @fgeyer16 should do the trick. Matching the allowed calculation methods of the data packages with the one calculation method of the study type can then be achieved in the
We could compare the selected Study area with the spatial extent field of the data package. This comparison could be done in the same But for a start I think it enough to compare only the calculation methods. Comparing locations could be added later as a new feature, once the system is already up and running. |
Can this be considered done? |
Basically yes. I implemenent this feature in this branch of the csis-helpers module. I just need to merge it into Dev. I wanted to wait, since I hoped for some more data packages in the system. With this feature enabled, some study types now might show just one available DP or none at all.... but it is what it is, so I'll enable this feature next week and close the issue. |
Done. The csis-helpers module now shows only published DPs with a calculation method fitting the selected Study type of current Study. ATM for the following Study types we have these DPs:
|
Related to: #90
Data packages can not be used with all study types. We need to somehow indicate which ones are compatible with what study types/calculation methods.
That is:
For discussion
1. How should we indicate the DP/study compatibility in the data package?
I can see two possibilities: either by linking to the study types or to the calculation method taxonomy. Both methods have advantages:
-- calculation method link: allows us to add new "screening" study types without changing the data package
-- study type link: allows us to differentiate e.g. between "expert" data packages with the urban infrastructure data and those with the transport infrastructure related data.
Q: Which one should we go for? Or even allow both and let the logic down the road deal with the potential issues?
2. Where to store this information?
As discussed earlier today, this information could be handled in the same way as other "tags", but this is a data package level information and the tags are in the ressources. So we may need to add (at least one) new field to the data_package.
Q:: any suggestions/opinions?
**3. How to ensure the compatibility of the DP and the study type/calculation method?
"Expert" data packages are relatively simple. They just have to provide all the data that we can visualize in the DP.
"Screening" DPs are not so simple, for two reasons:
Q:: any suggestions/opinions?
@p-a-s-c-a-l , all: WDYT?
The text was updated successfully, but these errors were encountered: