-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multipe Scenarios #74
Comments
See this comment for the current status of Study scenarios.
I believe this could easily be accomplished by the csis-helpers module. Currently working on it in the include-in-report feature branch. Adding the respective values from the |
I just noticed that multiple scenarios are enabled now.
Didn't test on other places. |
No, it's not working. See this Example:
Map iFrame Link generated: @patrickkaleta drupalSettings.csisHelpers.studyInfo: doesn't yet contain information on the active scenario: {
"id": "18",
"uuid": "5fa510eb-f21c-4cdc-88bf-c67ea6e83675",
"write_permissions": 1,
"name": null,
"step": "1905",
"step_uuid": "f7e661f7-c8f7-4b74-a248-1711fd21ea12",
"study": "18",
"study_uuid": "5fa510eb-f21c-4cdc-88bf-c67ea6e83675",
"study_emikat_id": 3186,
"calculation_status": "0",
"study_datapackage_uuid": "2434ce93-93d4-4ca2-8618-a2de768d3f16",
"study_area": "POLYGON((19.447474 51.764362,19.447474 51.781203,19.506651 51.781203,19.506651 51.764362,19.447474 51.764362))",
"eea_city_name": null,
"city_code": "PL002",
"study_presets": {
"time_period": "20710101-21001231",
"emission_scenario": "rcp85",
"event_frequency": "Rare",
"study_variant": "BASELINE"
},
"study_scenarios": [
{
"label": "2071-2100; 20y; no measures",
"time_period": "20710101-21001231",
"emission_scenario": "rcp85",
"event_frequency": "Rare",
"study_variant": "BASELINE"
},
{
"label": "2071-2100; 20y; effective",
"time_period": "20710101-21001231",
"emission_scenario": "rcp45",
"event_frequency": "Rare",
"study_variant": "BASELINE"
},
{
"label": "historical, 20y",
"time_period": "Baseline",
"emission_scenario": "Baseline",
"event_frequency": "Rare",
"study_variant": "BASELINE"
},
{
"label": "historical, yearly",
"time_period": "Baseline",
"emission_scenario": "Baseline",
"event_frequency": "Frequent",
"study_variant": "BASELINE"
},
{
"label": "2071-2100; yearly; no measures",
"time_period": "20710101-21001231",
"emission_scenario": "rcp85",
"event_frequency": "Frequent",
"study_variant": "BASELINE"
}
],
"is_anonymous": false,
"is_member": true
} Furthermore, Map Component JS Connector is still looking at field |
Time perio: 2071 - 2110 <--> 20710101-21001231 To me this URL fits to the selected scenario. Am I missing something?
The active scenario is stored in the field I can rename the |
Are you talking about this warning message? Yes. it wasn't affecting the system but still annoying, so I fixed it. |
Yes, you are right. I assumed that 'Business as usual' is RCP4.5 and 20 years is occasional. In my opinion, it would be better to use the same terminology in the UI and API. So either rcp85 or rcp85 (Business as usual) but not just Business as usual. Same for Event Frequency. Who knows that 20 years == rare? BTW, "Rare" will occur in other places in the UI, e.g. in the layer names or in the scenario analysis component. Same for RCP. Using different names for the same things is confusing, not only for end users. See also Naming things. |
I renamed the taxonomies so that UI and code models are aligned. Basic support for different scenarios is available. It could be improved by showing 2 scenarios at once, but that's a different issue. |
ATM there is a 1:1 mapping between Template Resources and the actual layer generated by substituting template variables. There is one set of variables for each scenario.
Although, we allow user to define more than one scenario, selecting more than one scenario isn't possible ATM. Handling of variables is already unnecessary complex, so we shouldn't additionally mix up different scenarios in one map. Instead, the user should be able to select a scenario from a drop down box which reloads the map with the new set of variables applied. When creating a screenshot via the "include in report button", information about the selected scenario should be added to the comment.
Scenario Comparison can be handled in the Scenario Analysis Component.
The text was updated successfully, but these errors were encountered: