Updated to use browserstack v2 API #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to use the browserstack v2 API to allow for OS specific browser workers. Also updated `map.js` to add previously unsupported browsers. jquery#19
|
There seems to be some issues with this revision. Specifically, workers seems to be endlessly queued regardless of their status reported by browserstack. Should be a simple fix to the logic that correlates running/queued workers with needed workers. I will continue to test this, and report back when i have a resolution. |
Fixed hashing of workers that was causing workers to not terminate as needed.
|
Hey thanks for the heads up. I added a fix for that issue and tested to ensure spawned workers were terminated correctly. |
|
(just for the record) ... because in API v1 [
{
"browser": {
"name": "chrome",
"version": "19.0"
},
"status": "running",
"id": 9254
}
]and in API V2: [
{
"os": "win",
"browser": "chrome",
"version": "19.0",
"status": "running",
"id": 506664
}
] |
|
working better now. EDIT: spoke too soon. still some slight issues. however they may be unrelated to this change. |
|
@Krinkle |
|
@Krinkle if thats the case, this is not a regression, and this pull request can be merged. |
|
This is confirmed by the fact that I'd recommend logging into the browserstack GUI and joining your swarm with IE7 manually to see what happens. At this point I don't know whether it is a regression in testswarm-browserstack, node-browserstack or browserstack's v2 API. In order to have more data to work from, I'll try to reproduce the issue myself as well with my own browserstack account, webserver and TestSwarm install. |
clarkbox
added a commit
that referenced
this pull request
Nov 14, 2012
Updated to use browserstack v2 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use the browserstack v2 API to allow for OS specific browser workers. Also updated
map.jsto add previously unsupported browsers. #19