Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sale ends at 00:00 instead of 11:59 PM on set day #342

Open
1 of 3 tasks
ghost opened this issue Sep 27, 2021 · 1 comment · Fixed by #343
Open
1 of 3 tasks

Sale ends at 00:00 instead of 11:59 PM on set day #342

ghost opened this issue Sep 27, 2021 · 1 comment · Fixed by #343
Labels
bug Something isn't working Has PR Issue has a PR.

Comments

@ghost
Copy link

ghost commented Sep 27, 2021

Describe the bug
The end date for a sale should be midnight on the date set for the sale to end. It currently end at 00:00 ie midnight of the day before.
This issue was fixed in WC 3.5.4
woocommerce/woocommerce#22186

To Reproduce
Steps to reproduce the behavior:

  1. Set a product to be on sale ending today (starting today or earlier)
  2. Visit the product page
  3. The sale price should be shown
  4. Change the sale end date to previous day
  5. The sale price now shows

Expected behavior
The sale should only end at the very end of the day (11:59 PM) and not when the day just starts.

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only Classic Commerce plugin is active.
  • This bug happens with a default ClassicPress theme active.
  • I can reproduce this bug consistently using the steps above.

ClassicPress Environment
Classic Commerce version: 1.0.3
CMS version: You are running ClassicPress Version 1.3.0

@ghost ghost added bug Something isn't working Has PR Issue has a PR. labels Sep 27, 2021
@ghost
Copy link
Author

ghost commented Oct 18, 2021

.

@ghost ghost closed this as completed Oct 18, 2021
@nylen nylen reopened this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Has PR Issue has a PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant