Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Facebook and Twitter preview #116

Closed
timbocode opened this issue Sep 1, 2020 · 3 comments
Closed

Remove Facebook and Twitter preview #116

timbocode opened this issue Sep 1, 2020 · 3 comments

Comments

@timbocode
Copy link
Contributor

...because things change. And there are proper tools for doing this:

https://cards-dev.twitter.com/validator
https://developers.facebook.com/tools/debug/

and it's something else to keep updated.

This is the FB preview in CPSEO (Social tab, page edit):

fb-preview

This is the FB preview using the FB tool for the same site:

fb-dev-preview

Not an exact match.

I'm thinking we still need to be able to add an image, title and description but I'm less convinced of the usefulness of the preview.

Thoughts?

@nylen
Copy link
Contributor

nylen commented Sep 1, 2020

I would probably leave these if it's not too much trouble. They are useful assuming they can be kept updated every so often, and they don't rely directly on an external API connection so they won't break completely.

@timbocode
Copy link
Contributor Author

Yeah, that's fair comment. If people find it useful, then it should stay in. It perhaps does need updating however.

As far as I can tell (looking through the obfuscated JS code), there is no link to FB or Tw. And also, when I load the page with dev tools open, there's no sign of any attempt to connect to 3rd party sites (other than gravatar.com and placeholder.com).

@timbocode
Copy link
Contributor Author

FB and Twitter previews to be retained. No further action required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants