Allowing dash on Tenant namespace #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are flaky and must be fixed, tested changes on |
|
Same on |
prometherion
force-pushed
the
issues/113
branch
2 times, most recently
from
d2ffd96
to
a3143e5
Compare
|
lgtm! |
prometherion
force-pushed
the
issues/113
branch
from
a3143e5
to
541960a
Compare
prometherion
force-pushed
the
issues/113
branch
from
541960a
to
46742a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement started from the discussion on #113 and addressing also #106.
We would like to be less strict regarding Tenant naming, allowing end-users to use dashes according to DNS RFC-1123, the same applied by Kubernetes for some resources.
I'd like to get a review from @MaxFedotov since he was the author of the force tenant prefix.