Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default labels to TCP resource #277

Closed
ptx96 opened this issue Mar 7, 2023 · 5 comments · Fixed by #337
Closed

Add default labels to TCP resource #277

ptx96 opened this issue Mar 7, 2023 · 5 comments · Fixed by #337
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@ptx96
Copy link
Contributor

ptx96 commented Mar 7, 2023

At the moment, any reference or example related to a TCP resource is without labels;

it would be advisable to add them (statically or dynamically) in order to better filter the target resources in case of interaction with other products (e.g. velero backup and restore procedure)

@ptx96 ptx96 added enhancement New feature or request good first issue Good for newcomers labels Mar 7, 2023
@prometherion
Copy link
Member

It seems to me we don't need any change in the code, rather, only some guidelines and best practices to share with the community.

@geoffrey1330
Copy link
Contributor

@prometherion I want to pick up this issue

@ptx96 ptx96 removed their assignment Jun 30, 2023
@prometherion
Copy link
Member

@geoffrey1330 thanks, let's wait first the feedback from @ptx96 since the issue/feature request is unclear in the objects and the desired goal.

@ptx96
Copy link
Contributor Author

ptx96 commented Jul 28, 2023

We should add a default label to the TCP resource inside every TCP yaml definition we wrote in the docs / samples section;

for example:

https://kamaji.clastix.io/getting-started/#tenant-control-plane

should be:

cat > ${TENANT_NAMESPACE}-${TENANT_NAME}-tcp.yaml <<EOF
apiVersion: kamaji.clastix.io/v1alpha1
kind: TenantControlPlane
metadata:
  name: ${TENANT_NAME}
  namespace: ${TENANT_NAMESPACE}
  labels:
    tenant.clastix.io: ${TENANT_NAME}
spec:
  dataStore: default
  controlPlane:
[...]

in order to be ready "out of the box" for side apps that use --selector logic;
here we have an example for velero:

https://velero.io/docs/v1.4/resource-filtering/#--selector


Thank you for offering to contribute @geoffrey1330 !

The files of interest for the issue should be as follows:
docs/content/getting-started.md
docs/content/guides/kamaji-azure-deployment.md
docs/content/guides/upgrade.md
docs/content/reference/benchmark.md
config/samples/kamaji_v1alpha1_tenantcontrolplane_konnectivity.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane_kine.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane_additionalvolumes.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane_additionalcontainers.yaml

@ptx96 ptx96 added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jul 28, 2023
@geoffrey1330
Copy link
Contributor

Could you please assign the issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants