-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default labels to TCP resource #277
Comments
It seems to me we don't need any change in the code, rather, only some guidelines and best practices to share with the community. |
@prometherion I want to pick up this issue |
@geoffrey1330 thanks, let's wait first the feedback from @ptx96 since the issue/feature request is unclear in the objects and the desired goal. |
We should add a default label to the TCP resource inside every TCP yaml definition we wrote in the docs / samples section; for example: https://kamaji.clastix.io/getting-started/#tenant-control-plane should be:
in order to be ready "out of the box" for side apps that use https://velero.io/docs/v1.4/resource-filtering/#--selector Thank you for offering to contribute @geoffrey1330 ! The files of interest for the issue should be as follows:docs/content/getting-started.md
docs/content/guides/kamaji-azure-deployment.md
docs/content/guides/upgrade.md
docs/content/reference/benchmark.md
config/samples/kamaji_v1alpha1_tenantcontrolplane_konnectivity.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane_kine.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane_additionalvolumes.yaml
config/samples/kamaji_v1alpha1_tenantcontrolplane_additionalcontainers.yaml |
Could you please assign the issue to me |
At the moment, any reference or example related to a TCP resource is without labels;
it would be advisable to add them (statically or dynamically) in order to better filter the target resources in case of interaction with other products (e.g. velero backup and restore procedure)
The text was updated successfully, but these errors were encountered: