Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted animation in sortable list when moving between multiple containers #64

Closed
vkammerer opened this issue Jan 19, 2021 · 4 comments · Fixed by #433
Closed

Unwanted animation in sortable list when moving between multiple containers #64

vkammerer opened this issue Jan 19, 2021 · 4 comments · Fixed by #433
Labels
bug Something isn't working

Comments

@vkammerer
Copy link

vkammerer commented Jan 19, 2021

Hello and thank you for the great library,

I noticed unwanted artefacts in my implementation of a dnd between multiple containers of sortable items, which was an adaptation of your <MultipleContainers /> component demoed in the story.

After a while debugging it, I realised the same visual glitch is present in the story itself.
In order to reproduce it, you can:

That's for the bug itself. Regarding the functionality's API (dragging items from a list to another): do you think users should implement the low level transferring from one list to another themselves, as visible in the current story, or do you think the library should include an easier solution?

@clauderic
Copy link
Owner

Hey @vkammerer, sounds like a bug. Could you record a video of the issue to help me visualize it?

@vkammerer
Copy link
Author

sure, here it is:

  • I drag A1 under A5 and all is correctly animated and positioned
  • look at the A column when A1 is drag onto the B list: the A items are animated again (even though they should remain still)
Screen.Recording.2021-01-20.at.2.53.03.PM.mov

@clauderic clauderic added the bug Something isn't working label Jan 20, 2021
@yuri-scarbaci-lenio
Copy link

is it a bug tho?
in the video what is happening is that you are resizing the container to fit the new list which has 1 less item then before, as in the list A is not re-animating, it's just re-sizing ?

@reverie
Copy link

reverie commented Feb 7, 2021

@yuri-scarbaci-lenio I think the bug isn't that the container resizes, but that A2-A5 "jump" a little when A1 leaves the container. If you remove the last item from a container, and the container shrinks, there should normally be no need to reposition the remaining items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants