Fix for using window as scrolling container

[aminland]

Right now, even in the story book, this is broken on chrome, ff, & edge.

This just fixes it to not use document.body to set the scroll. There was also an issue with double computation in the animateNodes function, where if the scrollcontainer was set to the parent, and we calculate both window and parent separately, it's a problem. So the key is to just use the scrollcontainer to SET the scroll value, and assume both window and container can scroll.

[ambewas]

@clauderic there are a number of issues open for this. Is it possible to review this PR and release a fixed version?

#332
#304
#291

[yuval-vibo]

Hi,
Any updates on this issue? waiting for a fix anxiously

[ambewas]

@yuval-vibo this has taken such a long time, I've forked the repo and published the dist folder myself.
Feel free to use this version where it has been fixed: https://github.com/ambewas/react-sortable-hoc

you can install it on npm like this:
npm install git+https://github.com/ambewas/react-sortable-hoc.git

@clauderic I'm sure a lot of people would like to see this fixed in the main package...

[yuval-vibo]

@ambewas Thanks Man!

[aminland]

Until this repo starts accepting pull requests, you can get our company's version from npm directly: npm install --save @fellow/react-sortable-hoc

[fabioimpe]

@aminland With your changes there's a strange behaviour in iOS:

then the item remains in that position until I perform a page refresh, even navigating between sections

[aminland]

@fabioimpe This should be fixed now.

[brybrophy]

@clauderic Any progress on getting this merged in? Considering forking and merging because a client is requesting a fix immediately, but I will hold if if you plan on merging this soon.

[rafael-sap]

I also need this fix!

[aminland]

I am maintaining the npm repo @fellow/react-sortable-hoc in light of this one not being maintained...

[mattes3]

Will this be merged in? I need it urgently because a client of mine is complaining, too!

I cannot use @fellow/react-sortable-hoc because the Typescript compiler won't import it because it cannot find @types/@fellow/react-sortable-hoc

So, I'm interested to get an official solution that also works with Typescript.

[EricFries]

Cool library--it would be great to see this fix get merged in.

[eveningkid]

This PR fixes it all. @clauderic, please, it would help everyone to have this merged...
@aminland's work saved my day. Thanks :)