Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit helperContainer prop from WrappedComponent #497

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

joepvl
Copy link
Contributor

@joepvl joepvl commented Jan 24, 2019

The helperContainer prop needs to be included in the list of omitted props when spreading props onto WrappedComponent. Otherwise, passing a DOM element string to SortableContainer will cause React to complain about the prop. Example:

const SortableTBody = SortableContainer('tbody')

Using <SortableTBody/> will generate the following:

Warning: React does not recognize the `helperContainer` prop on a DOM element. [...]

Thanks for adding the helperContainer feature, it allowed me to simplify some of my code!

Copy link
Owner

@clauderic clauderic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for submitting this PR!

@clauderic clauderic merged commit 12bafdf into clauderic:master Jan 25, 2019
@clauderic
Copy link
Owner

Released in 1.5.3

redking added a commit to DataDog/react-sortable-hoc that referenced this pull request Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants