Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claudia create/update should work well with patch-package #170

Closed
ceefour opened this issue Sep 25, 2018 · 2 comments
Closed

claudia create/update should work well with patch-package #170

ceefour opened this issue Sep 25, 2018 · 2 comments

Comments

@ceefour
Copy link

ceefour commented Sep 25, 2018

patch-package is very useful for forking/fixing a problem in the meantime before official bugfix.


  • Expected behaviour: deployed code runs patch-package (i.e. prepare script in package.json)

  • What actually happens: claudia npm installs the "pure packages" without running patches, this can be verified by using claudia --keep

  • Link to a minimal, executable project that demonstrates the problem: any project with any patch-package patch

  • Steps to install the project: claudia create / claudia update

  • Steps to reproduce the problem:

  1. npm install --save patch-package
  2. edit a file e.g. node_modules/aws-serverless-express/express/src/index.js even adding comment will do
  3. npx patch-package aws-serverless-express
  4. claudia create --keep ...
@ceefour
Copy link
Author

ceefour commented Sep 25, 2018

Workaround from @stojanovic :

you can use --use-local-dependencies option in Claudia and deploy whatever you have in your local node_modules, or simply fork a repo and fix the issue, just install the module from your fork, not from NPM.

@gojko gojko closed this as completed Sep 25, 2018
@gojko
Copy link
Member

gojko commented Sep 25, 2018

@ceefour one of the goals of Claudia is not to introduce too much magic, so we use NPM for package management. local dependencies are the right way to solve it, not a workaround, so I’ll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants