New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--no-optional-dependencies not working as expected #216
Comments
Possibly an npm version issue or something else in local environment. Have just looked at the package created as part of deployment (using Github action) and it doesn't contain aws-sdk! Maybe a Windows issue? |
After battling this for hours today, I THINK the issue is the
At this point
Still not installed
Now it's installed Running This is a total blocker for me. The size of the bundle is so large that my deploys are failing now. |
^ this is with latest Node (14). After downgrading to 13, |
More specifically, it's NPM 7 where Claudia has the issue with
|
Any resolution on this? |
Fixed. PR is pending #225. |
thanks, this is now published as v 5.14.0 |
Please use GitHub issues only to report bugs. To ask a general question or request assistance/support, please use the Claudia.js Gitter Chat instead.
To report a bug or a problem, please fill in the sections below. The more you provide, the better we'll be able to help.
Expected behaviour:
optional dependencies such as aws-sdk are not included in zip
What actually happens:
aws-sdk is included.
Link to a minimal, executable project that demonstrates the problem:
Steps to install the project:
install aws-sdk as optional dependency
npm i -O aws-sdk
Steps to reproduce the problem:
claudia update --no-optional-dependencies
Please note
it appears that claudia packages with the following npm command:
npm install -q --no-package-lock --no-audit --production --no-optional
if I remove the --no-package-lock option, then the optional dependencies are correctly omitted.
The text was updated successfully, but these errors were encountered: