Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Markdown roxygen2 #51

Closed
maelle opened this issue Jan 30, 2023 · 6 comments · Fixed by #52
Closed

use Markdown roxygen2 #51

maelle opened this issue Jan 30, 2023 · 6 comments · Fixed by #52

Comments

@maelle
Copy link
Contributor

maelle commented Jan 30, 2023

I'll make a PR in a sec.
@maelle maelle mentioned this issue Jan 30, 2023
Merged
@krlmlr
Copy link
Contributor

krlmlr commented Mar 30, 2023

Done now?

@maelle
Copy link
Contributor Author

maelle commented Mar 30, 2023

Right, good catch!

@maelle maelle closed this as completed Mar 30, 2023
@maelle
Copy link
Contributor Author

maelle commented Mar 30, 2023

so weird that merging the PR didn't close this automatically 🤔

@maelle
Copy link
Contributor Author

maelle commented Mar 30, 2023

oh not weird at all, it hadn't been merged to the default branch, it makes sense. 😌

@ClaudioZandonella
Copy link
Owner

Yes sorry, I always merge first in the develop branch and then merge in the master.

Do you suggest merging directly in the master is a better approach?

@maelle
Copy link
Contributor Author

maelle commented May 29, 2023

@ClaudioZandonella no, any git workflow is fine! I'm more used to merging to the default branch, that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: activate Markdown syntax for roxygen2 maelle/trackdown
3 participants
@krlmlr @maelle @ClaudioZandonella