Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test roundtrip #61

Closed
krlmlr opened this issue Mar 30, 2023 · 2 comments
Closed

Test roundtrip #61

krlmlr opened this issue Mar 30, 2023 · 2 comments

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Mar 30, 2023

If there is no file on the Google Drive, I would find it useful if trackdown performed a no-op roundtrip: reimport the unchanged document so that any bogus changes are weeded out right in the beginning.

Example: any extra newlines before headings are removed by trackdown::download_file() . Ideally, when starting work on trackdown, I would commit those changes first, before importing any real edits.
ClaudioZandonella added a commit that referenced this issue May 28, 2023
@ClaudioZandonella
Fix issue removed lines after download
f548f34 
Issue #61. Now document keept the same as the original during upload/download if no changes are made online
ClaudioZandonella added a commit that referenced this issue May 28, 2023
@ClaudioZandonella
trackdown 1.5.1
9c66484 
- Fix compatibility with `googledrive` version `2.1.0`. `googledrive` and `gargle` packages changed underlying functions and arguments for managing Google api authentication. Now `trackdown` is aligned with the changes. See Issue #57 #59 #62.
- Add lifecycle badges. See Issue #52.
- Fix unwanted removed lines at download. See Issue #61
@ClaudioZandonella
Copy link
Owner

Hi @krlmlr,

The idea of a no-op roundtrip is very useful to solve possible introductions of unwanted meaningless changes during upload download🔝.

At the moment, I just fixed the issue of new lines being removed. If there are other inconsistencies I will try to fix them directly in the code. Obtaining the same document when uploading-downloading during a no-op roundtrip is useful to spot other possible issues in the code and fix them.

I close the issue, but if you find other cases with unwanted changes do not hesitate to report them! Next time I will be much faster in fixing them😅

@krlmlr
Copy link
Contributor Author

krlmlr commented Jul 10, 2023

Thanks. I think the idea of a roundtrip test is still valid, it could be run unconditionally (or optionally) before each upload too, just to be sure.

Roundtrip will matter much more if we take a stab at #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krlmlr @ClaudioZandonella