Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable protocol #124

Merged
merged 2 commits into from Aug 25, 2022
Merged

Conversation

lilactown
Copy link
Collaborator

@lilactown lilactown commented Aug 24, 2022

PR for implementing the JS iterable protocol as an actual Clava protocol that can be extended to Clava types, addressing #125

@borkdude
Copy link
Member

PR looks good to me, but what is the issue being addressed? The issue mentioned is the same as the PR id

@borkdude
Copy link
Member

Maybe one consideration: in CLJS there is a IIterable protocol which has a -iterable method. Should we take those names or stick with the current ones?

@lilactown
Copy link
Collaborator Author

I tried to make an issue, but magit seems to have lied to me. Will create an issue explaining it later

@lilactown lilactown mentioned this pull request Aug 24, 2022
@borkdude borkdude merged commit cf1ca3c into squint-cljs:main Aug 25, 2022
borkdude pushed a commit that referenced this pull request Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants