Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add focus states #39

Closed
wants to merge 1 commit into from
Closed

add focus states #39

wants to merge 1 commit into from

Conversation

scottaohara
Copy link

add :focus selectors to <a> and <button> elements Set focus states for <a> and <button> elements to provide parity for mouse and keyboard interactions.

add `:focus` selectors to `<a>` and `<button>` elements Set focus states for `<a>` and `<button>` elements to provide parity for mouse and keyboard interactions.
@claviska
Copy link
Member

Good call — in Chrome/Firefox the default outlines appear on focus, but not in Safari and likely other browsers.

I'd prefer to add a proper focus state instead of reusing the hover state, and consistency across browsers is highly desirable. I really like how BS4 beta buttons handle this, but we need access to color modifiers to make it happen without setting arbitrary variable values.

@scottaohara
Copy link
Author

Agreed, a unique focus state would be best, but I just went with the idea of "get something in there because reusing hover is better than nothing" rather than "let me try to guess what design aesthetic you would want" :)

totally cool with cancelling this PR if you want to design these yourself.

@claviska
Copy link
Member

This was fixed yesterday in the buttons rework. Thanks for the heads up 👍

@claviska claviska closed this Aug 18, 2017
@scottaohara scottaohara deleted the add_focus_states branch August 18, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants