Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize getCommandParts function #46

Closed
clawcastle opened this issue Mar 19, 2021 · 0 comments · Fixed by #48
Closed

Memoize getCommandParts function #46

clawcastle opened this issue Mar 19, 2021 · 0 comments · Fixed by #48
Labels
enhancement New feature or request

Comments

@clawcastle
Copy link
Owner

Right now, the getCommandParts function is probably the one that is called the most often in the entire application, as it is invoked multiple times for each command. It could easily be memoized to greatly reduce the amount of string arrays allocated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Memoized getCommandParts function clawcastle/sound-boart
1 participant
@clawcastle