Fix table and list item: paragraph in these nodes do not need newline #57
Fix table and list item: paragraph in these nodes do not need newline #57
Conversation
This fixes lists, but there's still a problem with nested lists. This .rst:
becomes this Markdown:
which spaces the entire list. |
@SilverRainZ why did you create a fork? |
Because I don't own this repository and the maintainer hasn't replied to me for a year, see #59 |
😭😭😭😭 Thank you @SilverRainZ for your contribution. Will the real repository owner please stand up, please stand up, please stand up. Eminem - The Real Slim Shady (Official Video - Clean Version) |
@vktry-k-it you can try my fork: https://github.com/sphinx-notes/markdown-builder |
Many thanks. I've tried 0.5.6, however i'm still getting mumbo-jumbo output, and additionally very verbose console output.
I've used the Sphinx examples for testing. Should i open an issue for that on your end, or we good? I'm just going to avoid writing tables, it's just for the markdowns of the repository (README, etc.) anyway. There must be more than tables to markdown. There Must Be More to Life Than This (Freddie Mercury with Michael Jackson) |
@vktry-k-it The output is debug log, it is fine and should not influence the markdown output. |
I know, it's just too verbose for my taste if it's the defaults. Like i said, main point is: it isn't working. Thanks anyway! |
@vktry-k-it get it, you can report the bug at sphinxnotes's side, I will try to debug. |
Thank you! |
A paragraph maybe child of a table entry or list item, we should not add newline in these cases. See commit message and comments of code.
Table
rST source:
Generated markdown:
After this patch:
List
rST source:
Generated markdown:
After this patch: