Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider: patch array contains to use like #38

Closed
cldellow opened this issue Jan 29, 2023 · 0 comments
Closed

consider: patch array contains to use like #38

cldellow opened this issue Jan 29, 2023 · 0 comments

Comments

@cldellow
Copy link
Owner

https://github.com/simonw/datasette/blob/0b4a28691468b5c758df74fa1d72a823813c96bf/datasette/filters.py#L313-L324 does json_each to test array membership.

This is, of course, the right way to do it.

...but probably we would get by just fine if we did column like '%"string-value"%, which seems to be 3x faster:

json_each query

yolo everything is a string query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cldellow