Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed control over duration, lowered min range+doc #12

Merged
merged 2 commits into from Jan 11, 2021

Conversation

brunotacca
Copy link
Contributor

Addition to #5.
The conditional for duration was pushing it back to 2000ms when below 1000ms.
Users might want more control over the duration (Personal thought, 1000ms was still slow for me).

  • Adjusted the conditional statement, fixing the control over the duration.
  • Adjusted the lower limit from the duration from 1000ms to 100ms.
  • Added more documentation for the parameter duration.

@Bestfastfire Bestfastfire merged commit 3d02491 into clean-code-dev:master Jan 11, 2021
@Bestfastfire
Copy link
Member

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants