Fix to avoid PHP-FPM's bug #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP-FPM has a bug with STDIN: https://bugs.php.net/bug.php?id=73342 Running `clean-css-cli` in a PHP's `exec` will hit the bug, and PHP-FPM master's process will peak at 100% CPU usage. Ignoring the `stdin` test if there's no argument can avoid the bug.
|
Hum, failing on node 8.x, but I don't know why. Can you help me on this one @jakubpawlowicz? Thanks a lot for your work! |
|
I know it's been ages since your PR but I've just rebuilt tests and they pass. Since the change looks sensible I'm going to merge it. |
|
It's out in v4.3.0. |
|
Thanks @jakubpawlowicz, I can finally remove my patch script :-) Thanks again for this software and your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP-FPM has a bug with STDIN: https://bugs.php.net/bug.php?id=73342
Running
clean-css-cliin a PHP'sexecwill hit the bug, and PHP-FPM master's process will peak at 100% CPU usage.Ignoring the
stdintest if there's no argument can avoid the bug.