Release react 5.0.0-alpha.0 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ To aid in merge conflict resolution
* 5.0.0-wip cherry-pick from 5.1.0-wip — CPLAT-357: React 16 from NPM and Bundled with Webpack # Conflicts: # lib/react_client/react_interop.dart # lib/react_test_utils.dart
* 5.0.0-wip cherry-pick from 5.1.0-wip — testEvent logic could create false positives # Conflicts: # pubspec.yaml
Cplat 4310 pointer events
CPLAT-4335 Add deprecations in preparation for 5.0.0 # Conflicts: # lib/react.dart # lib/react_client/react_interop.dart # lib/react_test_utils.dart
CPLAT-4789: fix string refs # Conflicts: # lib/react_dom.js # lib/react_dom.js.map # lib/react_dom_prod.js # lib/react_dom_prod.js.map # lib/react_dom_server.js # lib/react_dom_server.js.map # lib/react_dom_server_prod.js # lib/react_dom_server_prod.js.map # test/factory/common_factory_tests.dart # test/factory/dart_factory_test.dart # test/factory/dom_factory_test.dart
Moving things around inevitably creates issues
- omit types on intializing formals - update package.json - update webpack - remove unused dart-helpers.js - rebuild bundles - remove out-dated tests # Conflicts: # lib/react.dart # lib/react.js.map # lib/react_client.dart # lib/react_client/js_interop_helpers.dart # lib/react_client/react_interop.dart # lib/react_prod.js # lib/react_prod.js.map # lib/react_test_utils.dart # lib/react_with_addons.js.map # lib/react_with_react_dom_prod.js # lib/react_with_react_dom_prod.js.map # package-lock.json # package.json # test/js_interop_helpers_test/shared_tests.dart # test/util.dart
+ To prevent the dartfmt command from producing different output using the Dart 1 SDK vs. the Dart 2 SDK during CI
# Conflicts: # lib/react_client.dart
+ Do not show in IDE analyzer view + Also seen in over_react: Workiva/over_react@3eceba3
Add bindings for React Portals
# Conflicts: # pubspec.yaml
… clean up implementations
Fix eventdata
| /// [children] can be any renderable React child, such as a [ReactElement], [String], or fragment. | ||
| /// | ||
| /// See: <https://reactjs.org/docs/portals.html> | ||
| static ReactPortal createPortal(dynamic children, Element container) => ReactDOM.createPortal(children, container); |
There was a problem hiding this comment.
@greglittlefield-wf @joebingham-wk @kealjones-wk just confirming that this is an intentional addition in a major release instead of waiting for the subsequent minor?
There was a problem hiding this comment.
That's right, so that consumers (like WSD) are able to transition from react_dom.render to portals.
|
|
|
+1, merging |
This was referenced Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactJS 16.x Support
.jsfiles provided by this package are now ReactJS version 16.5.1.0.FYA: @greglittlefield-wf @kealjones-wk @joebingham-wk @sydneyjodon-wk