CPLAT-10894 Rethrow and print registerComponent/registerComponent2 errors #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended review: Whitespace changes only
Problem
Currently, registerComponent calls that throw have their errors swallowed by React if they occur in the call stack of a component render (due to the render triggering lazy evaluation of a top-level factory variable).
This can commonly happen if:
Changes:
_registerComponent
and_registerComponent2
, add a try-catch-rethrow that also logs the error, in case it's swallowed by React_registerComponent2
only: add more specific try-catch-rethrows around defaultProps/propTypes accesses, since that's usually what throwsprints
matcher to verify the error is printedQA