Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hey there! If you're a dev, read this :) #4

Closed
cleanlock opened this issue Mar 30, 2022 · 14 comments
Closed

Hey there! If you're a dev, read this :) #4

cleanlock opened this issue Mar 30, 2022 · 14 comments
Labels
help wanted Extra attention is needed

Comments

@cleanlock
Copy link
Owner

cleanlock commented Mar 30, 2022

Hey there!

I'm glad to see that @mikirobles already pushed some changes to this repo. I'd like to get this extension on the Chrome Webstore, so other people can just easily install this extension.

I need some help to migrate it from Manifest v2 to v3. So if you're down for that, feel free to push to this repo. I'll review and merge them afterwards, and ofcourse everyone who's pushing changes which will get merged, will receive credits.

Let's keep this extension donation- and ref-link free.

Thanks for reading <3

@HatterTheMadd
Copy link
Contributor

Just forked it. Working on it now.
Thanks <3

@cleanlock
Copy link
Owner Author

Just forked it. Working on it now. Thanks <3

Glad to see! :) Thanks for your effort in advance <3

I've already paid the register-fee on the Chrome Webstore. Feel free to push your changes anytime :)

@cleanlock cleanlock pinned this issue Mar 30, 2022
@cleanlock cleanlock added the help wanted Extra attention is needed label Mar 30, 2022
@cleanlock
Copy link
Owner Author

cleanlock commented Mar 30, 2022

@HatterTheMadd Hey! Thanks for updating the manifest.json. I just found one (hopefully little) issue.

Chrome is reporting: 'webRequestBlocking' requires manifest version of 2 or lower.

Edit: Seems like webRequestBlocking is deprecated in v3 and the whole extension will need an update. Just removing it from the manifest will get the error itself away, but the extension actually stops doing its job at blocking Ads on Twitch when using v3.

@HGGamers
Copy link

Thanks for doing this :)

Will you also add Firefox?

@cleanlock
Copy link
Owner Author

Thanks for doing this :)

Will you also add Firefox?

Hi, I think Firefox will come soon as well. Some stuff for the Chrome extension needs to be done first for example updating do manifest v3 and updating the whole extension so it actually works again with manifest v3 so the extension can be published to the Chrome Webstore.

@HGGamers
Copy link

No problem, in Firefox the addon has not yet been updated with the amazon ref-link anyway.

@cleanlock
Copy link
Owner Author

No problem, in Firefox the addon has not yet been updated with the amazon ref-link anyway.

That's good to hear, but it will probably follow. :/ It's really sad to see how greedy people get when it's about money.

@HGGamers
Copy link

Even if the update comes now, it does nothing for me, because I have already disabled autoamtic updates for the addon.

@cleanlock
Copy link
Owner Author

Even if the update comes now, it does nothing for me, because I have already disabled autoamtic updates for the addon.

Oh perfect then! :) stay safe, friend.

@gitguest54
Copy link

Sad to see this happening since all the issues I reported he always tackled them quickly and was very helpful and nice. This didn't seem too bad in my opinion, but it just completely breaks the trust for sure. Now my question is, will this be a community supported thing with future updates to fix bugs and stuff or will this only be a re-upload of an older version of the addon?

@cleanlock
Copy link
Owner Author

Sad to see this happening since all the issues I reported he always tackled them quickly and was very helpful and nice. This didn't seem too bad in my opinion, but it just completely breaks the trust for sure. Now my question is, will this be a community supported thing with future updates to fix bugs and stuff or will this only be a re-upload of an older version of the addon?

Hi, I try to keep it up2date as best as I can. And I hope that others will also contribute/help as much as they can. :)

@john-d-pelingo
Copy link

I would love to help, but I have never developed an extension for Google Chrome. Do you have a good resource to get started and how to test this locally?

Otherwise, I'll probably be digging in the docs.

@cleanlock
Copy link
Owner Author

I would love to help, but I have never developed an extension for Google Chrome. Do you have a good resource to get started and how to test this locally?

Otherwise, I'll probably be digging in the docs.

I'm kinda new to Chrome Extensions too, not gonna lie. You can simply download the source and just load the extension (see README). I'm currently trying to update it to Manifest v3.

You'll probably have to dig the docs, unfortunately :/ I'm doing the same, and also digging stackoverflow.

@cleanlock
Copy link
Owner Author

Update to Manifest v3 was successful!

@cleanlock cleanlock unpinned this issue Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants