Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host with port generates invalid signature #3

Open
severien opened this issue May 1, 2020 · 1 comment
Open

Host with port generates invalid signature #3

severien opened this issue May 1, 2020 · 1 comment

Comments

@severien
Copy link

severien commented May 1, 2020

Hi, I have been testing this library and noticed that when using a host with port the library generates a signature without the port as host header.
Example: http://localhost:8080

Expected header in canonical request.
host:localhost:8080

Actual header used for canonical request:
host:localhost

@theherk
Copy link

theherk commented May 2, 2020

Interesting. One wouldn't intuit that the host header wants both the host and the port, but it does. Good find. I'll bet they'd accept a pull request that fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants