Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gocritic linter #717

Open
mdhorn opened this issue Apr 24, 2020 · 0 comments
Open

Enable gocritic linter #717

mdhorn opened this issue Apr 24, 2020 · 0 comments
Labels
Bucket: Code Quality Improvement to code quality or maintainability low priority medium impact bug with a work-around or a functional bug with a low impact

Comments

@mdhorn
Copy link
Contributor

mdhorn commented Apr 24, 2020

Enable the gocritic linter for golangci-lint and fix the flagged issues.

We should consider these settings when implementing:

gocritic:
  enabled-tags:
    - diagnostic
    - experimental
    - opinionated
    - performance
    - style
  disabled-checks:
    - dupImport # https://github.com/go-critic/go-critic/issues/845
    - ifElseChain
    - octalLiteral
    - whyNoLint
    - wrapperFunc

The output of this all seems reasonable and worth implementing.
Many of these may be overlapped with Enable gosimple linter #714

@mdhorn mdhorn added low priority medium impact bug with a work-around or a functional bug with a low impact Bucket: Code Quality Improvement to code quality or maintainability labels Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bucket: Code Quality Improvement to code quality or maintainability low priority medium impact bug with a work-around or a functional bug with a low impact
Projects
None yet
Development

No branches or pull requests

1 participant