Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawler not picking up license for component listed in pypi.org #433

Open
mpcen opened this issue Jun 15, 2021 · 1 comment
Open

Crawler not picking up license for component listed in pypi.org #433

mpcen opened this issue Jun 15, 2021 · 1 comment

Comments

@mpcen
Copy link
Member

mpcen commented Jun 15, 2021

py-healthcheck (https://pypi.org/project/py-healthcheck/) is listed having an MIT license.

Crawler does not declare MIT

https://clearlydefined.io/definitions/pypi/pypi/-/py-healthcheck/1.7.2

@qtomlinson
Copy link
Collaborator

qtomlinson commented Nov 14, 2023

This issue has been fixed my previous commit. So it should be resolved if a component harvest is retriggered. See the correct license information in dev UI.

One improvement that I can see upon my previous fix is to postpone the declared license calculation to the service layer (instead of the current calculation/extraction in the crawler). All the information needed to compute/extract declared license has already been persisted by the crawler, so there is no need to re-run the scanners (tools) during a crawler harvest. Only a re-computation of definition (in service) is required to correct the license information, which is a lot cheaper than a re-harvest by the crawler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants