Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dangling tooltips #364

Closed
jeffmcaffer opened this issue Nov 11, 2018 · 4 comments
Closed

dangling tooltips #364

jeffmcaffer opened this issue Nov 11, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@jeffmcaffer
Copy link
Member

jeffmcaffer commented Nov 11, 2018

From time to time it seems that tooltips are not going away. In the screenshot below not there are two tooltips. The "Revert" tip is actually stuck up. Even if I move to a different area where there are no tips at all, it stays up, The Copy tip OTOH comes and goes as expected. I've notices this as well quite a bit with the tip for the "Revert Changes" button

image

Note that I seem to be able to make it happen (in Chrome) by moving the mouse "promptly" over the button. slow enough that the tip pops up but fast enough that you are not lingering.

@storrisi storrisi self-assigned this Nov 12, 2018
@storrisi storrisi added this to To do in November 2018 via automation Nov 12, 2018
@storrisi storrisi added this to the November 2018 milestone Nov 12, 2018
@storrisi storrisi moved this from To do to In progress in November 2018 Nov 30, 2018
@storrisi
Copy link
Contributor

Seems like this is a knows issue of ant-design when there is a Tooltip on a disabled Button, as explained here: ant-design/ant-design#9581

I've tried to replace the Tooltip with the Bootstrap one, but it doesn't work on elements that are not buttons, like a DropDown for example.

Maybe we can hide the tooltip if the button is disabled?

@storrisi storrisi moved this from In progress to Under Review in November 2018 Nov 30, 2018
November 2018 automation moved this from Under Review to Done Dec 3, 2018
@dabutvin
Copy link
Member

dabutvin commented Dec 5, 2018

2018-12-04 16 22 08

I was able to repro this issue with the bootstrap button - seems like there is an underlying browser bug at play here that is affecting both kinds of buttons + tooltips

@dabutvin dabutvin reopened this Dec 5, 2018
November 2018 automation moved this from Done to In progress Dec 5, 2018
@storrisi
Copy link
Contributor

storrisi commented Dec 5, 2018

Looks like it shows up randomly, and due to the fact that the button is disabled, it doesn't disappear.
I'm gonna check into this again.

@storrisi
Copy link
Contributor

storrisi commented Dec 5, 2018

I've found this issue opened into the react-boostrap repo, react-bootstrap/react-bootstrap#1588 , but applying the suggested solution doesn't seem to solve the problem

November 2018 automation moved this from In progress to Done Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
November 2018
  
Done
Development

No branches or pull requests

3 participants