Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the solidity code up to date with the coding standards #321

Closed
AntoineRondelet opened this issue Nov 25, 2020 · 2 comments
Closed
Assignees
Labels
code-quality Task related to the code quality (refactor, enhancements etc.) solidity Task related to the Solidity part of the code base

Comments

@AntoineRondelet
Copy link
Contributor

The PR #318 added some basic and missing code standards for the solidity code. Several files are not compliant with it (in fact, as of now some contracts code styles conflict) and follow different conventions. Let's bring all these files up to date with the solidity code standards to have a consistent code.

In the same time, we may want to use solhint (https://github.com/protofire/solhint) as solidity linter to enforce best practices (code/style) and check these on the CI server.

@AntoineRondelet AntoineRondelet added code-quality Task related to the code quality (refactor, enhancements etc.) solidity Task related to the Solidity part of the code base labels Nov 25, 2020
@AntoineRondelet AntoineRondelet self-assigned this Dec 15, 2020
@AntoineRondelet
Copy link
Contributor Author

Despite #333 being merged, this ticket remains opened since the smart contract code is not fully compliant with the solidity standards (doing so would have cause too many changes for a single PR). This will be done incrementally. As such, this ticket remains until the whole code satisfies the solidity coding standards.

@AntoineRondelet
Copy link
Contributor Author

#361 has brought the contract code up to date with the solidity standards overall. We made amendments to the coding standards of solidity to fit our needs, but the functions' interfaces etc are now compliant.
Closing this issue as a consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Task related to the code quality (refactor, enhancements etc.) solidity Task related to the Solidity part of the code base
Projects
None yet
Development

No branches or pull requests

1 participant