Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize zeth contracts #94

Closed
AntoineRondelet opened this issue Oct 24, 2019 · 3 comments
Closed

Optimize zeth contracts #94

AntoineRondelet opened this issue Oct 24, 2019 · 3 comments
Assignees
@dtebbs
Labels
optimization Optimization task solidity Task related to the Solidity part of the code base

Comments

@AntoineRondelet
Copy link
Contributor

Let's do a pass on the smart contracts to try and optimize them in order to reduce the gas cost of the state transitions
@AntoineRondelet
Copy link
Contributor Author

Related issues: #71 #72

@AntoineRondelet AntoineRondelet added optimization Optimization task solidity Task related to the Solidity part of the code base labels Oct 24, 2019
@rrtoledo
Copy link
Contributor

rrtoledo commented Oct 24, 2019 •
edited

I already started fixing these in the fix-todo branch.
edit: I already corrected variables being explicitly initialized to their null values.

@AntoineRondelet AntoineRondelet mentioned this issue Feb 5, 2020
Merged
@AntoineRondelet
Copy link
Contributor Author

AntoineRondelet commented Feb 5, 2020 •
edited

Closing this issue as it consisted in doing a first pass on the smart contracts to optimize the gas consumption of their execution. This has been done as part of #138 which has been merged. Further optimizations can be reported in new tickets, and addressed in new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtebbs dtebbs

Labels
optimization Optimization task solidity Task related to the Solidity part of the code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dtebbs @rrtoledo @AntoineRondelet