Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require 'bowser/http' #2

Closed
fazibear opened this issue Apr 1, 2016 · 4 comments
Closed

require 'bowser/http' #2

fazibear opened this issue Apr 1, 2016 · 4 comments

Comments

@fazibear
Copy link

fazibear commented Apr 1, 2016

Requiring browser/http is not enough, you need to require also bowser/event_target witch can be fixed quick.
@jgaskins
Copy link
Member

jgaskins commented Apr 1, 2016

I thought bowser/event_target was loaded by requiring bowser.

I think there was a weird 3-way circular dependency between Event, EventTarget, and Window / Document that kept it from being able to be loaded explicitly by one of them. I can't remember off the top of my head.

@fazibear
Copy link
Author

fazibear commented Apr 1, 2016

Sure, but if I want require only http module ? You can require bowser/event_target few times. Its not a problem.

@jgaskins
Copy link
Member

jgaskins commented Apr 1, 2016

Yeah, I very much prefer to require all dependencies of the current file. I probably just overlooked it here. I was just kinda thinking out loud about it, tbh. :-)

@jgaskins
Copy link
Member

Fixed in 894838e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fazibear @jgaskins