Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jl_set_global going away #34

Closed
robertu94 opened this issue Aug 15, 2022 · 2 comments
Closed

jl_set_global going away #34

robertu94 opened this issue Aug 15, 2022 · 2 comments
Labels
acknowledged the team is aware of this issue will_be_accepted PR or feature request will be implemented at a later point

Comments

@robertu94
Copy link

Jluna uses a function jl_set_global which seems to be going away in an upcoming version https://docs.julialang.org/en/v1.9-dev/manual/embedding/. I wasn't sure what the easy work around was otherwise I would have created a PR to adapt to this change.
@robertu94 robertu94 mentioned this issue Aug 15, 2022
Closed
@Clemapfel Clemapfel added acknowledged the team is aware of this issue will_be_accepted PR or feature request will be implemented at a later point labels Aug 16, 2022
@Clemapfel
Copy link
Owner

Thank you for making me aware of this, functionality-wise it's pretty easy to replace by just writing a Julia-side function and loading it on jluna::initialize, but the nice thing about jl_set_global is that it's super fast so I need to do some benchmarking to find a valid replacement.

I'll keep this open until I then, it shouldn't be that much work.

@Clemapfel
Copy link
Owner

Fixed by JuliaLang/julia@3c3ec2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged the team is aware of this issue will_be_accepted PR or feature request will be implemented at a later point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertu94 @Clemapfel