Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work within a <Pane/> element with name parameter set #52

Closed
nemosmithasf opened this issue Feb 5, 2021 · 4 comments
Closed

Comments

@nemosmithasf
Copy link

The element throws an error when placed a element (but not when directly as a child to )

See below for error:

Screen Shot 2021-02-04 at 7 09 52 PM

@clementallen
Copy link
Owner

Hi @nemosmithasf

Can you please share a codesandbox which replicates this issue? It will help me more easily understand and debug it.

Here's a template that may help: https://codesandbox.io/s/react-leaflet-textpath-hps8j

@nemosmithasf
Copy link
Author

Here you go: https://codesandbox.io/s/react-leaflet-textpath-forked-ku7q4?file=/src/index.js:489-507

It seems like its not <Pane/> that is the problem, its the name parameter

@nemosmithasf nemosmithasf changed the title Does not work within <Pane/> elements Does not work within a <Pane/> element with name parameter set Feb 5, 2021
@clementallen
Copy link
Owner

Thanks for the very useful codesandbox!

I've done some investigation and it unfortunately looks to be an issue with the underlying Leaflet.TextPath library not supporting Panes. The library is fairly old and not seen active development for a while so is unlikely to be fixed there anytime soon.

Here are some issues I found relating to this problem in their repo:

makinacorpus/Leaflet.TextPath#83
makinacorpus/Leaflet.TextPath#69
makinacorpus/Leaflet.TextPath#45

@nemosmithasf
Copy link
Author

I see, that's a shame. Thanks for looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants