Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSSIM VAE is not working with 3D inputs #68

Closed
ravih18 opened this issue Dec 19, 2022 · 2 comments · Fixed by #69
Closed

MSSSIM VAE is not working with 3D inputs #68

ravih18 opened this issue Dec 19, 2022 · 2 comments · Fixed by #69

Comments

@ravih18
Copy link
Contributor

ravih18 commented Dec 19, 2022

Hello @clementchadebec

MSSSIM VAE model returns an error when using 3D images for training.

Indeed the MSSSIM implementation in benchmark_VAE/src/pythae/models/msssim_vae/msssim_vae_utils.py only works for 2 images.

I found the following implementation that seems to work with 3D images: https://github.com/VainF/pytorch-msssim.

I can make a PR to add it if you think it is a good idea.

Otherwise I can see if I can generalize the current implementation for 3D images !

Let me know what do you think of it.

Ravi

@clementchadebec
Copy link
Owner

Hello @ravih18,

Thank you for opening this issue. You are absolutely right, the current implementation of VAE-MSSSIM only supports 2D images. Having an implementation that supports 3D images would indeed be a very nice feature.

As for the PR, sure! Thanks for suggesting it. Feel free to send a PR as this feature may be interesting for other users as well! I would be happy to look into it :) Feel free to contact me if you have any questions about integrating this feature into the code base.

Best,

Clément

@clementchadebec clementchadebec linked a pull request Jan 5, 2023 that will close this issue
@clementchadebec
Copy link
Owner

Completed in #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants