Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game saves breaks replays #5

Closed
clementgallet opened this issue Apr 13, 2016 · 3 comments
Closed

Game saves breaks replays #5

clementgallet opened this issue Apr 13, 2016 · 3 comments

Comments

@clementgallet
Copy link
Owner

We should prevent games from saving. This should be done quite easily by hooking file IO functions and preventing file writing.

@clementgallet
Copy link
Owner Author

Writing into regular files is not prevented (be67570 and e9abac2).

@clementgallet
Copy link
Owner Author

Add more fileio hooks (cf72cfb), but still problems with Braid, probably because the savefile is modified in another way (deleted or truncated). So we must deal with this. A simple idea is to switch opening those files to readonly so we should have explicit error messages.

@clementgallet clementgallet reopened this May 8, 2016
@clementgallet
Copy link
Owner Author

Change of strategy: now we make a copy of any file considered as a save file, and open the copy (66563ec). This is a much easier method and seems to work great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant