Feature request: Album art in Library window #785
Comments
|
From john.maguire on September 22, 2010 05:58:34 Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low Component-UI |
|
From keirangtp on December 29, 2010 16:06:35 Issue 976 has been merged into this issue. |
|
From markwatkinson on December 31, 2010 07:32:25 I'd like to see this as well. I've attached a patch proposal and preview image of what it does (in artist -> album grouping and just album grouping). There are two things that don't work so well in my patch:
Attachment: clentine_library_art.png clentine_library_art1.png clementine_library_art.diff |
|
From ivanovnegro on December 31, 2010 07:39:42 Its not bad. Looks good. |
|
From andrew.gaydenko on December 31, 2010 07:53:32 For my eyes suggested screenshots has a drawback: adjacent pictures are glued. I'm sure a little background gap will greatly improve overall vision. |
|
From himynameiszacHandiamapirate on December 31, 2010 08:42:50 I agree that there should be some spacing between adjacent covers. As long as this is made toggle-able (use/don't use covers in pane), I'm very much for the functionality. Being able to turn it off is key for anyone using a very thin sidebar. |
|
From himynameiszacHandiamapirate on December 31, 2010 08:46:08 I'd also say that the amarok 2 sidebar coevrs are a bit smaller than the mockup (or is that a screenshot? Haven't tried the patch). once again for the sake of space, I'd probably go with the smaller size, especially since there are at least two more places where a person can see it larger if necessary. |
|
From himynameiszacHandiamapirate on December 31, 2010 08:46:42 Badass music, by the way :) |
|
From markwatkinson on December 31, 2010 10:32:01 thanks :P yep, it's a screenshot. The art size is 48x48px but it's pretty arbitrary and could easily be made a bit smaller. I agree it would look better with a pixel or two of vertical separation, but I haven't figured out how to do that yet (or more accurately, I haven't figured out how to do it ONLY for albums). |
|
From bendarb on December 31, 2010 14:24:23 looks great here, using debian squeeze there is nice spacing between the album covers as attached screenshot. Attachment: clementine-library-album.png |
|
From markwatkinson on January 01, 2011 03:49:08 Updated version and screenshots are attached. The images are now spaced by a few pixels, and for comparison, they are also shrunk to 30x30 which is the same as in the Amarok2 screenshot. Personally I think they look better at 48x48 though. Attachment: clentine_library_art2_1.png clentine_library_art2_2.png clementine_library_art2.diff |
|
From markwatkinson on January 01, 2011 06:27:22 On second thoughts, being a Qt noob, I realised afterwards that the spacing can be applied by different KDE/Qt styles (as in bendarb's screenshot, comment #10) and the previous method could apply superfluous padding to people whose style already has some. So I think the neater way to space them is by the widget's stylesheet, but it applies padding globally to all items in the library tree regardless of whether they're an album image or not. On the other hand, I don't think anyone would notice if you didn't tell them. Also, this way is one extra line of code whereas the other was about 50 or something. Updated patch attached. Attachment: clementine_library_art3.diff |
|
From ivanovnegro on January 01, 2011 09:19:33 Wow, man, I like the smaller ones more and it looks awesome, its the way I really want to see it implemented. |
|
From himynameiszacHandiamapirate on January 01, 2011 11:14:20 whistles Very impressive. I do like the smaller covers, they take up just a bit less horizontal space, and look more like delicious candies :) Excellent work! And do you want to like, hang out or something? Great tunes. If you're trying to impress us, it's working (on me, at least). |
|
From davidsansome on January 02, 2011 06:51:24 This issue was closed by revision r2548 . Status: Fixed |
|
From davidsansome on January 02, 2011 06:52:58 This looks really good! I've committed your patch with a couple of changes: it will now cache the little images after it's loaded them so it's not continuously loading and scaling down potentially huge images, also it will reset the model after changing the setting - it's fine to do that, most other things do! Keep em coming ;) |
|
From keirangtp on January 02, 2011 07:05:17 Labels: Milestone-0.7 |
|
From ivanovnegro on January 02, 2011 07:20:50 I cannot believe it, its done yet. |
|
From davidsansome on January 02, 2011 07:29:26 Don't thank me, I hardly did anything! |
|
From ivanovnegro on January 02, 2011 07:33:36 Yes, I forgot to mention, to thank the creator of this stuff, markwatkinson, but you implemented it, really good team work. |
|
From andrew.gaydenko on January 02, 2011 07:37:14 Thanks to all participants for resolving the issue! Friends, what do you think about following consideration? At case when covers are not found for this and that albums, album list looks rather... irregular. I imagine small default icon can be used to arrange a tree in a regular and eyes-firendly manner (the same as used for "now playing" widget). |
|
From himynameiszacHandiamapirate on January 02, 2011 08:27:01 I would agree with that. |
|
From keirangtp on January 02, 2011 09:34:03 I agree. Is somebody willing to take care of this? Looks simple enough. ;) Status: Accepted |
|
From markwatkinson on January 02, 2011 09:55:34 I'm not quite sure I understand. Are we referring to making the not-found icon the same size as the artwork to make it all neater? Something like this? [attached] Attachment: clentine_library_art2_5.png |
|
From andrew.gaydenko on January 02, 2011 10:05:45 Yes, you are right!! |
|
From himynameiszacHandiamapirate on January 02, 2011 10:16:24 Indeedio. |
|
From markwatkinson on January 02, 2011 10:49:08 Ah, right. Yeah, the reason I didn't include something like that originally was because I assumed the not-found image would be changed to a 32x32 version of the little round CD icon taken from whatever icon set Clementine uses (oxygen?) which is kind of hard to do with a diff. I hadn't spotted nocover.png, which in fact, looks a lot better. Patch attached. Attachment: clementine_library_art_nocover.diff |
|
From davidsansome on January 02, 2011 10:59:11 This issue was closed by revision r2561 . Status: Fixed |
From ioansolteanu on September 21, 2010 20:52:19
It would be great to have the album art displayed next to the album title in the Library window, either by default or as an option in the Settings menu.
Attachment: amarok46si4.png
Original issue: http://code.google.com/p/clementine-player/issues/detail?id=785
The text was updated successfully, but these errors were encountered: